Declare istanbul-lib-instrument so coverage is reproducible - #130
Merged
Conversation
@angular/build's karma builder resolves the instrumenter from the top level, and the lock file carried it only nested under karma-coverage - so 'ng test --code-coverage' failed before instrumenting anything: The 'istanbul-lib-instrument' package is required for code coverage but was not found. Declaring it directly hoists it. Verified from a clean npm ci: 105 specs pass and coverage reports 100% statements, functions and lines, 98.57% branches. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWkVh7cyAz1gWapBH1CY8n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ng test --code-coveragecurrently fails outright from a clean clone:@angular/build's karma builder resolves the instrumenter from the top level, and the lock file carried it only nested underkarma-coverage. Declaring it directly hoists it.This is the last piece of the coverage work — without it the 100% figure isn't reproducible by anyone else.
Verified from a clean
npm ci: 105 specs pass, coverage reports 100% statements, 100% functions, 100% lines, 98.57% branches.npm auditclean.🤖 Generated with Claude Code