build(deps): bring UnitTests onto the same test packages as IntegrationTests (dapper) - #129
Merged
Merged
Conversation
…onTests (dapper) The two test projects on this branch had drifted apart: Microsoft.NET.Test.Sdk 18.9.0 (Integration) vs 18.8.1 (Unit) xunit.runner.visualstudio 4.0.0 (Integration) vs 3.1.5 (Unit) Main has both projects on 18.9.0 and 4.0.0. This is residue from the pre-grouping era: #114 and #115 came off dependabot/nuget/tests/TodoApp.IntegrationTests/dapper branches and edited only the project each was named for, leaving UnitTests behind. The grouped sweep introduced by #126 would have caught this up - it reads dependabot.yml from the default branch, so the dapper target-branch entries apply here too. That sweep ran on 2026-08-17 as run 32038120956 and died in setup, unable to download github/dependabot-action through a 429 during the GitHub partial outage that afternoon. Dependabot's own update jobs are not retryable ("This workflow run cannot be retried"), so the sweep never produced a pull request and the drift stayed put. Hence this by hand. Nothing was broken by the split: the two test projects do not reference each other, so there is no NU1605 downgrade to trip on and dapper's CI was green throughout. The cost was quieter - unit tests were running on a test runner a major version behind the integration tests. Only UnitTests' lock file changes. `dotnet restore --force-evaluate` rewrites all six on Windows, but the other five differ by line endings alone and were reverted rather than committed as churn. Verified locally on the 10.0.100 SDK, pinned via a temporary global.json because CI floats on 10.x and the machine defaults to a 10.0.400 preview: locked-mode restore passes with no NU1004, Release build is clean under TreatWarningsAsErrors, and all 98 tests pass - including the 65 unit tests now discovered and run by the 4.0.0 runner, which is the only real risk in a major runner bump. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the test-package drift between the two test projects on
dapper.mainalready has both projects on 18.9.0 / 4.0.0.Why it drifted
Residue from the pre-grouping era. #114 and #115 came off
dependabot/nuget/tests/TodoApp.IntegrationTests/dapperbranches and edited only the project each was named for, leaving UnitTests behind.The grouped sweep from #126 would have caught this up — Dependabot reads
dependabot.ymlfrom the default branch, so thedappertarget-branch entries apply here. That sweep ran as run 32038120956 and died in setup on a 429 downloadinggithub/dependabot-action, during the GitHub partial outage that afternoon. Dependabot's own update jobs aren't retryable:So the sweep never opened a PR and the drift stayed. Hence this by hand.
Nothing was broken
The two test projects don't reference each other, so there was no NU1605 downgrade to trip on and
dapper's CI was green throughout. The cost was quieter: unit tests were running on a test runner a major version behind the integration tests.Scope
Only UnitTests' lock file changes.
dotnet restore --force-evaluaterewrites all six on Windows, but the other five differ by line endings alone and were reverted rather than committed as churn.Verification
Local, on the 10.0.100 SDK — pinned via a temporary
global.json, since CI floats on10.xand this machine defaults to a 10.0.400 preview:dotnet restore TodoApp.sln --locked-modepasses, no NU1004TreatWarningsAsErrors🤖 Generated with Claude Code