Upload coverage reports to Codecov from CI - #17
Merged
Conversation
The CI workflow computed a coverage profile but never uploaded it, so the Codecov badge kept showing stale data from long before the current test suite existed. Add the codecov-action upload step using the repository's existing CODECOV_TOKEN secret; upload failures are non-fatal so Codecov outages cannot break the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Codecov badge shows ~11% because nothing ever uploads coverage — the badge reflects stale data from long before the current test suite. Our CI computes
coverage.outand prints the summary in the log, but the report never left the runner.This adds the
codecov/codecov-action@v5upload step using the repository's existingCODECOV_TOKENsecret (already configured — verified via the API).fail_ci_if_error: falsekeeps Codecov outages from breaking the build.Once this merges and CI runs on main, the badge should update to the real number (~74% of statements across
./pkg/..., measured with-coverpkg).Test plan