-
Notifications
You must be signed in to change notification settings - Fork 3
[WIP] Dune Table Create/Insert #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bh2smith
wants to merge
8
commits into
main
Choose a base branch
from
127/dune-insert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f871749
Dune Table Create/Insert
bh2smith 5b956bf
Add Type Map and Fix Tests
bh2smith 4d441c0
Merge branch 'main' into 127/dune-insert
bh2smith b38d67e
Fix bad merge
bh2smith f34c058
Skip Create & Updated Tests
bh2smith 40d827e
Test Table Exists
bh2smith 73f4914
reintroduce upload_csv and unstable replace
bh2smith 7af60c4
Stash forgotten changes as commit
bh2smith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| """Common structures used in multiple destination implementations.""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| """Data Type mappings.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Any | ||
|
|
||
| from sqlalchemy import BIGINT, BOOLEAN, DATE, TIMESTAMP, VARCHAR | ||
| from sqlalchemy.dialects.postgresql import ( | ||
| BYTEA, | ||
| DOUBLE_PRECISION, | ||
| INTEGER, | ||
| NUMERIC, | ||
| ) | ||
|
|
||
| DECIMAL_PATTERN = r"decimal\((\d+),\s*(\d+)\)" | ||
| VARCHAR_PATTERN = r"varchar\((\d+)\)" | ||
|
|
||
| DUNE_TO_PG: dict[str, type[Any] | NUMERIC] = { | ||
| "bigint": BIGINT, | ||
| "integer": INTEGER, | ||
| "varbinary": BYTEA, | ||
| "date": DATE, | ||
| "boolean": BOOLEAN, | ||
| "varchar": VARCHAR, | ||
| "double": DOUBLE_PRECISION, | ||
| "real": DOUBLE_PRECISION, | ||
| "timestamp with time zone": TIMESTAMP, | ||
| "uint256": NUMERIC, | ||
| } | ||
|
|
||
| # https://docs.dune.com/api-reference/tables/endpoint/create#body-schema-type | ||
| # This map is not a perfect inverse of the one above. | ||
| # 1. Notice `DOUBLE_PRECISION` has two pre-images: we chose double | ||
| # 2. timestamp with time zone not aligned with timestamp | ||
| # 3. Apparently no JSONB support here. | ||
| PG_TO_DUNE: dict[int, str] = { | ||
| 16: "boolean", | ||
| 17: "varbinary", | ||
| 20: "bigint", | ||
| 21: "bigint", # smallint | ||
| 23: "integer", | ||
| 25: "varchar", | ||
| # 26: "oid", | ||
| 700: "double", | ||
| 701: "double", | ||
| 1042: "varchar", | ||
| 1043: "varchar", | ||
| 1082: "timestamp", | ||
| 1114: "timestamp", # This doesn't match with above | ||
| 1700: "uint256", | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,4 +37,4 @@ jobs: | |
| query_string: SELECT 1; | ||
| destination: | ||
| ref: dune | ||
| table_name: table_name | ||
| table_name: table.name | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,4 +16,4 @@ jobs: | |
| query_string: foo.sql | ||
| destination: | ||
| ref: dune | ||
| table_name: table_name | ||
| table_name: table.name | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That the end to end test is expected to fail because it is reading a remote file from main. Once this PR lands. The file will be updated and the e2e test will pass again.