Conversation
bh2smith
commented
Dec 25, 2024
bh2smith
added a commit
that referenced
this pull request
Dec 26, 2024
This PR started as a coverage improvement. However, we found that config did not need to be async and simplified that flow. There was also a bug with `make run` (the sample config) introduced in #130 with the `DataFrame` to `TypedDataFrame` switch. This resolves all of that while bringing coverage to 96% (also ignoring main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an inconsistency with the types returned from postgres and those being passed in.
PG.fetch returned
DataFramebut
PG.save expected
TypedDataFrameResulted in a bug where data.is_empty did not exist.
This PR aligns the types naively, but this will all be improved in a follow up #129 (which assigns proper/non-empty types) to Postgres dataframes.