Repository navigation
feat(ffmpegtool): probe the language tag and build multi-output argv - #182
Merged
Merged
Conversation
The sidecar step (docs/specs/spec-subtitle-sidecars.md) needs each stream's language and one ffmpeg process writing several outputs. The tag rides the existing single -show_entries query, so no extra ffprobe process is spent. build_argv stays untouched so every existing argv pin holds. Closes #176 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Stream.language(fromstream_tags=languagein the existing probe query; absent tag gives empty string), the frozenOutputSpec(options, muxer, path)andbuild_multi_output_argv(ffmpeg, src, outputs).build_argvis unchanged. Decision recorded in the spec's Decision log.Verification:
scripts/verify.pygreen (lint, format, 1371 tests). New tests pin the probe query, language parsing with/without tags, and a two-output argv including dash-leading paths.Closes #176
🤖 Generated with Claude Code