Repository navigation
feat(batch): write sidecars abort-safely after the ladder - #185
Merged
Merged
Conversation
A sidecar-declaring profile now gets a separate ffmpeg step after the winning rung and its verification: plan, name, existing-path check, one multi-output process, then every sidecar renamed before the output, so an output at its final path implies its sidecar step finished. A failing step or rename costs only the sidecar and is named in a note; an existing sidecar is never replaced without --overwrite. Stale sidecar partials are swept by name grammar at task start, in the outer BaseException net and in the interrupt's stuck-future clean-up. Result gains sidecars. Refs docs/specs/spec-subtitle-sidecars.md Closes #179 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Extract the post-failure probe and its termination check into a helper after threading overwrite pushed the function to 55 lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
batchruns the sidecar step after verification:plan_sidecars->sidecar_paths-> existing-path check -> stale partials removed -> one multi-output ffmpeg -> sidecar renames -> output rename.WrittenSidecar(path, stream, language)andResult.sidecars.converted. A failed output rename staysfailedand keeps the renamed sidecars._handle_interrupt;_raise_if_terminatedtakes every partial.Verification
scripts/verify.pygreen (1459 passed); new tests intests/test_batch.pycover every Acceptance bullet with a test-local probe-first sidecar profile.Closes #179
🤖 Generated with Claude Code