Repository navigation
feat(profiles): write web's text subtitles as WebVTT sidecars - #187
Merged
Merged
Conversation
No browser shows an in-band mov_text track, so a film played through --to web lost its subtitles. WEB's subtitle rule now declares a WebVTT sidecar for every text codec; bitmap subtitles stay dropped with a note, and the last-resort note no longer claims text subtitles are lost. README documents naming, the existing-sidecar rule, the --overwrite backfill and the new `sidecars` JSON key. Spec: docs/specs/spec-subtitle-sidecars.md Closes #181 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change: WEB's subtitle rule declares a WebVTT Sidecar (text codecs; ASS/SSA styling note); drop_reason now bitmap-only; last_resort note reworded; README documents sidecars and the
sidecarsJSON key. Spec: docs/specs/spec-subtitle-sidecars.mdVerification: scripts/verify.py green (lint, format, 1466 tests). New tests: argv pin (H.264, AAC, 2x eng SubRip, ASS, PGS), plan_sidecars, run_batch end-to-end with stubbed ffmpeg incl. JSON record.
Closes #181
🤖 Generated with Claude Code