fix: remove NPM_RELEASE_ENABLED gate from release workflow - #46
Merged
Merged
Conversation
Trusted publishing is configured for all three npm packages and the release workflow already requires a manual workflow_dispatch on main, so the repository-variable gate is redundant. Remove it and update RELEASING.md accordingly.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…cleanup # Conflicts: # RELEASING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Result
npm trusted publishing is configured for all three packages, so the
NPM_RELEASE_ENABLEDrepository-variable gate on the release job is removed. The workflow still only runs via a manualworkflow_dispatchagainstmain(unchanged), so publishing still requires an explicit maintainer action — it just no longer needs an extra variable toggled first.Changes
.github/workflows/release.yml: drop theif: vars.NPM_RELEASE_ENABLED == 'true'condition and its comment on thereleasejob.RELEASING.md: remove the instruction to setNPM_RELEASE_ENABLED; note that trusted publishing is already configured.Validation
pnpm install(husky/lint-staged ran on commit, staged files formatted with oxfmt).pnpm -r tscpassed on commit via the pre-commit hook.release.ymlagainstRELEASING.mdto confirm no other references toNPM_RELEASE_ENABLEDremain (grep -rn NPM_RELEASE_ENABLED .returns nothing outside git history).