fix(release): remove obsolete NPM_RELEASE_ENABLED gate - #52
Merged
Merged
Conversation
npm trusted publishing is fully configured for hdrify, hdrify-cli, and hdrify-react, and the release baseline tag exists, so the manual activation gate on the release job is no longer needed. This aligns the release workflow with sibling repos that don't carry this gate. Refs #51
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: vars.NPM_RELEASE_ENABLED == 'true'gate (and its comment) from thereleasejob in.github/workflows/release.yml, since npm trusted publishing is now fully configured forhdrify,hdrify-cli, andhdrify-react, and the release baseline tag exists.RELEASING.mdto remove references to setting the now-obsoleteNPM_RELEASE_ENABLEDActions variable.guardjob (dispatch-against-main check) and baseline-tag mechanics are untouched.Closes #51
Validation
git diffreviewed: only the gate lines and the twoNPM_RELEASE_ENABLEDmentions inRELEASING.mdchanged.