Repository navigation
build(deps): upgrade vitest to v5 - #70
Merged
Merged
Conversation
typescript was already ^7.0.2 (no-op for this PR). vitest / @vitest/coverage-v8 -> ^5.0.1; no config API changes or source changes were needed. Closes #69
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bhouston
added a commit
that referenced
this pull request
Sep 25, 2026
Closes #71 ## Summary Deferred from stage 1 (#68): `unicorn/no-new-array` was kept `"off"` because turning it on surfaced 10 pre-existing errors in `pizHuffman.ts` and `b44Codec.test.ts`. - Replaced `new Array(n)` with `Array.from({ length: n })` at all 8 call sites in `pizHuffman.ts` and 2 in `b44Codec.test.ts`. - Added an explicit `Array.from<number>({ length: n })` type argument at the two untyped call sites (`hufTableBuffer`, `freq` in `hufUncompress`) — `new Array(n)` without an annotation inferred `any[]`, so removing it surfaced real `tsc` errors (arithmetic on possibly-`unknown`/`null` values) that needed the explicit type to keep compiling; behavior is unchanged since every one of these arrays is fully populated by index before being read elsewhere (the dense-vs-sparse difference between `Array.from` and `new Array` doesn't matter for direct index access). - `.oxlintrc.json`: flips `unicorn/no-new-array` to `"error"`, now byte-identical to canonical alongside the other two tightened rules (already enabled since stage 1). ## Validation - `pnpm build`, `pnpm tsc`, `pnpm lint`, `pnpm exec oxfmt --check .` pass - `pnpm exec vitest run packages/hdrify/src/exr/b44Codec.test.ts` (the touched test file): 8/8 pass - `pnpm test --coverage` (full suite): running; watching PR CI on dedicated runners for the authoritative result (local EXR-decode tests intermittently time out on this machine under load, as noted in #68/#70) - `node /path/to/standards/check-drift.mjs <repo>`: clean, no exceptions remaining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
Summary
typescriptwas already^7.0.2on main (no-op for this PR).vitest/@vitest/coverage-v8:^4.1.10->^5.0.1. No config API changes or source changes were needed.Validation
pnpm build,pnpm tsc,pnpm lint,pnpm exec oxfmt --check .passpnpm release:checkpasses (12/12)pnpm size: hdrify 42.15 kB / 50 kB, hdrify-react 17.19 kB / 22 kB (unchanged)pnpm test --coverage: running locally (heavy EXR-decode suite; watching PR CI on dedicated runners for the authoritative result, per the same note as chore: standardize CI/tooling to v2 canonical (stage 1) #68)