Repository navigation
fix: skip lint-staged failure when only ignored files are staged - #78
Merged
Merged
Conversation
Add --no-error-on-unmatched-pattern to the oxfmt and oxlint --fix invocations in the lint-staged config so staging only a generated or otherwise ignored file (e.g. routeTree.gen.ts) no longer fails the commit when both tools end up with zero matched files. Refs #77
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-error-on-unmatched-patternto theoxfmtandoxlint --fixinvocations in thelint-stagedblock ofpackage.json(JS/TS entry and the json/md/yamloxfmtentry).routeTree.gen.ts), since both tools then see zero matched files and exit non-zero.Closes #77
Test plan
git commiton this branch (staging onlypackage.json) ran the pre-commit hook successfully with the new flag.