Repository navigation
test: smoke-test the built VS Code extension bundle - #84
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
Behavior
Adds a test that loads the built
dist/extension.jswith a stubbedvscodemodule and callsactivate(), so load-time/interop breakage (cf.sharp_1.default is not a functionin sharp-image-vscode-extension) fails CI instead of shipping. Included in the root vitest config; CI already runspnpm buildbeforepnpm test.Validation
pnpm build,pnpm tsc,pnpm lint,pnpm testpass locally (754 passed). Confirmed the test fails whenactivateis made to throw in the bundle and passes on the real bundle.