Fixing specs #10
Open
Fixing specs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hmmm. Lots of simple errors. Really wish I knew where this stood 2 years ago. I think the number of actual errors is going to be pretty small, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I spent a few hours fixing some of the stuff that seemed obviously wrong. Some of it was Ruby 1.9.3 compatibility, some of it was broken/inconsistent specs, and some of it was (apparently) bugs in Quantity itself.
Most of the low-hanging fruit is fixed, but I'm still not clear what's wrong with the rest of the specs, or how to fix them. Once there's a Travis build I'll point out some specific problems for us to discuss.