removed old results#10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes previously committed experiment artifacts (dataset split CSVs, training configs, and trained model checkpoints) from the repository.
Changes:
- Deleted multiple dataset split CSV files under
results/splits/. - Deleted saved training configurations (
args.json) for several experiments. - Deleted trained model checkpoint files (
best_model.pt) for several experiments.
Reviewed changes
Copilot reviewed 12 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| results/splits/tcga_nsclc_study_60_15_25_0.csv | Removed NSCLC (LUAD/LUSC) train/val/test split CSV. |
| results/splits/tcga_luad_tp53_60_15_25_0.csv | Removed LUAD TP53 train/val/test split CSV. |
| results/splits/tcga_hnsc_hpv_cv3_0.csv | Removed HNSC HPV CV3 fold split CSV. |
| results/splits/camelyon16_tumor_85_15_orig_0.csv | Removed Camelyon16 tumor split CSV. |
| results/nsclc/transmil/best_model.pt | Removed NSCLC TransMIL checkpoint. |
| results/nsclc/transmil/args.json | Removed NSCLC TransMIL exported run configuration. |
| results/nsclc/attnmil/best_model.pt | Removed NSCLC AttnMIL checkpoint. |
| results/nsclc/attnmil/args.json | Removed NSCLC AttnMIL exported run configuration. |
| results/luad_tp53/transmil/best_model.pt | Removed LUAD TP53 TransMIL checkpoint. |
| results/luad_tp53/transmil/args.json | Removed LUAD TP53 TransMIL exported run configuration. |
| results/luad_tp53/attnmil/best_model.pt | Removed LUAD TP53 AttnMIL checkpoint. |
| results/luad_tp53/attnmil/args.json | Removed LUAD TP53 AttnMIL exported run configuration. |
| results/hnsc_hpv/transmil/best_model.pt | Removed HNSC HPV TransMIL checkpoint. |
| results/hnsc_hpv/transmil/args.json | Removed HNSC HPV TransMIL exported run configuration. |
| results/hnsc_hpv/attnmil/best_model.pt | Removed HNSC HPV AttnMIL checkpoint. |
| results/hnsc_hpv/attnmil/args.json | Removed HNSC HPV AttnMIL exported run configuration. |
| results/camelyon/transmil/best_model.pt | Removed Camelyon TransMIL checkpoint. |
| results/camelyon/transmil/args.json | Removed Camelyon TransMIL exported run configuration. |
| results/camelyon/attnmil/best_model.pt | Removed Camelyon AttnMIL checkpoint. |
| results/camelyon/attnmil/args.json | Removed Camelyon AttnMIL exported run configuration. |
Comments suppressed due to low confidence (2)
results/splits/tcga_nsclc_study_60_15_25_0.csv:1
- README.md states that split files are provided under
results/splits, but this PR deletes this split file (and likely the wholeresults/splitsdirectory). This makes the README inaccurate and removes the exact case split needed to reproduce experiments. Either keep the split CSVs in-repo (perhaps under a non-results/path), or update the README to explain how to regenerate them and/or where to download the canonical splits (e.g., a release asset).
results/nsclc/transmil/args.json:1 - This PR removes the exported training configuration (
args.json). README.md currently claims that the best hyperparameter configurations and checkpoints are provided underresults/; after this removal, users won’t be able to reproduce the reported runs from the repository alone. Consider moving these artifacts to a release/Zenodo link (and reference it in the README) or keep lightweight configs (args JSON + metrics) in-repo while excluding large checkpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.