Skip to content

fix(workflow): mark resumed rework as in progress - #15

Merged
big-mon merged 2 commits into
mainfrom
codex/rework-in-progress
Sep 24, 2026
Merged

big-mon merged 2 commits into
mainfrom
codex/rework-in-progress

Conversation

@big-mon

@big-mon big-mon commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Context

Rework issues currently retain that status while the agent works, making resumed execution look like pending feedback.

TL;DR

Move Rework to In Progress when implementation resumes.

Summary

  • Verify attached PR targets before reading feedback or updating the workpad from it.
  • Record human feedback in the existing workpad before changing the issue state.
  • Move the issue to In Progress and read it back before resuming implementation.
  • Preserve the bound clone, matching PR and unfinished work.

Alternatives

  • Keeping Rework during execution hides whether the agent has resumed work.
  • Concurrent manual state edits during kickoff remain outside this change.
  • No engine change is needed; the workflow already directs Linear state updates.

Test Plan

  • Full env -u __BURRITO ERL_FLAGS='+S 4:4' make -C elixir all: passed; 299 tests, 0 failures, 6 skipped; Dialyzer passed.
  • Two default-scheduler runs hit existing retry-timer bounds; rerun with 4 Erlang schedulers, tests unchanged.
  • python3 tests/test_repository_workflow.py: 17 tests passed.
  • YAML parsing and strict Liquid rendering passed for the canonical and installed workflows.
  • git diff --check passed; reviewed feedback capture, state read-back and existing-work preservation.
  • Observe a real Rework -> In Progress transition on the next approved rework run.

Record human feedback in the existing workpad, then move Rework to
In Progress and confirm the state before implementation resumes.
Preserve the bound clone, PR and unfinished work so the visible state
reflects active execution without restarting the task.

Validation: make -C elixir all passed (299 tests, 0 failures, 6 skipped),
17 repository routing tests passed, YAML and Liquid rendering passed,
and git diff --check passed. Live state transition remains unverified.

Co-authored-by: Codex <codex@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T13:54:15.470215Z 862419c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3500dca0e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread WORKFLOW.md
Comment thread WORKFLOW.md
Move attached-PR validation ahead of feedback processing and workpad
planning so the Rework sequence makes the existing repository boundary
explicit. Preserve target verification before PR mutations.

Validation: full gate passed on rerun after two existing timer-bound
failures; 299 tests, 0 failures, 6 skipped. Repository routing checks
(17 tests), YAML/Liquid rendering and diff checks passed.

Co-authored-by: Codex <codex@openai.com>
@big-mon

big-mon commented Sep 24, 2026

Copy link
Copy Markdown
Owner Author

[codex] Review follow-up at 862419c:

  • Clarified the shared sequence: verify attached PR targets before reading their feedback or changing the workpad from it. The installed workflow is aligned.
  • Declined the additional state-recheck guard under the existing operating policy: concurrent manual status changes during kickoff are outside this change, and a second read would not make the mutation atomic. The original thread records the rationale.
  • Full local validation passed with 4 Erlang schedulers: 299 tests, 0 failures, 6 skipped; Dialyzer clean. Two default-scheduler runs hit existing retry-timer bounds. Routing tests (17), YAML/Liquid rendering, diff and PR-body checks passed. Live Rework transition remains unverified.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 862419c898

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@big-mon
big-mon merged commit c24f600 into main Sep 24, 2026
3 checks passed
@big-mon
big-mon deleted the codex/rework-in-progress branch September 24, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant