fix(core): remove decorative price element from accessibility tree #2829
+27
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Remove decorative price element from accessibility tree by adding
aria-hidden="true", improving screen reader experience by preventing duplicate price announcements.Migration
Update
core/vibes/soul/sections/cart/client.tsx:{lineItem.salePrice && lineItem.salePrice !== lineItem.price ? ( <span className="font-medium @xl:ml-auto"> - <span className="line-through">{lineItem.price}</span> {lineItem.salePrice} + <span aria-hidden="true" className="line-through"> + {lineItem.price} + </span>{' '} + {lineItem.salePrice} </span> ) : ( <span className="font-medium @xl:ml-auto">{lineItem.price}</span> )}