Skip to content

Conversation

@jorgemoya
Copy link
Contributor

What/Why?

Remove decorative price element from accessibility tree by adding aria-hidden="true", improving screen reader experience by preventing duplicate price announcements.

Migration

Update core/vibes/soul/sections/cart/client.tsx:

        {lineItem.salePrice && lineItem.salePrice !== lineItem.price ? (
          <span className="font-medium @xl:ml-auto">
-           <span className="line-through">{lineItem.price}</span> {lineItem.salePrice}
+           <span aria-hidden="true" className="line-through">
+             {lineItem.price}
+           </span>{' '}
+           {lineItem.salePrice}
          </span>
        ) : (
          <span className="font-medium @xl:ml-auto">{lineItem.price}</span>
        )}

@jorgemoya jorgemoya requested a review from a team as a code owner January 20, 2026 21:54
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: db9f6dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
catalyst Ready Ready Preview, Comment Jan 20, 2026 9:55pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants