Add ebike charger, display/remote, and wiring harness component types - #49
Merged
Conversation
Follows the existing Ebike Battery/Ebike Motor convention (Drivetrain group, "Electric Bike ..." secondary name) for three e-bike electronics components. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Renames the five electric component types from "Ebike X" to "e-vehicle X" (lowercase prefix, broader e-vehicle term), with "Electric Vehicle X" secondary names. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bike_index serves components.csv, but the repo renamed it to component_types.csv (#46). The script still wrote a stray components.csv. Now it saves that download under the maintained name so a bare run refreshes the data/ files correctly. - Save the components download as ${outdir}component_types.csv. - Normalize the output dir's trailing slash so "data" and "data/" both work. - Update csvs_spec to read the renamed reference (tmp/component_types.csv). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e-vehicle electronics to the component types taxonomy and fixes the bike_index download script.
e-vehicle Charger,e-vehicle Display/Remote, ande-vehicle Wiring Harnesstodata/component_types.csv, and renames the existingEbike Battery/Ebike Motorto thee-vehicleform (lowercase prefix,Electric Vehicle …secondary names). TheUI/Remotehandlebar HMI maps toe-vehicle Display/Remote.bin/download_from_bike_indexto save thecomponents.csvdownload under the maintained namecomponent_types.csv(renamed in Rename component_types, brake_types, drivetrain_attributes CSVs #46) instead of dropping a straycomponents.csv, so a bare run refreshes thedata/files correctly. Also normalizes the output dir's trailing slash.csvs_specto read the renamed reference (tmp/component_types.csv).