Add 6in, 6.5in, and 9in e-scooter wheel sizes - #52
Merged
Merged
Conversation
Follow-up to bf1d814 (#50). Adds the three remaining e-scooter tire sizes so they resolve automatically: - 6in (6 x 1 1/4, 150 x 30) — small kick/e-scooters (e.g. ES1) - 6.5in solid tire — Hiboy S2 Lite and hoverboard-style scooters - 9in (9 x 2) — Hiboy S2R Plus and other 9in e-scooters Inserted in iso_bsd sort order. BSD values are best estimates: 6in ~90 from the 150 x 30 geometry, 6.5in ~110 for the small solid-tire rim, and 9in ~145 between the 8.5in (134) and 10in (152) beads. Authoritative ETRTO codes for these scooter tires aren't consistently published, so no ISO codes are asserted in the descriptions where unconfirmed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sethherr
marked this pull request as ready for review
July 1, 2026 16:10
sethherr
added a commit
to bikeindex/bike_index
that referenced
this pull request
Jul 1, 2026
Mirrors bikeindex/bike_data#52. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sethherr
added a commit
to bikeindex/bike_index
that referenced
this pull request
Jul 2, 2026
…ype (#3789) Three related registration data additions, plus a drivetrain edit-form behavior for the new Pinion gears. - **Pinion Gearbox front gears** — `6`, `9`, `12`, `18 Speed Pinion Gearbox` (internal `FrontGearType`), listed in the drivetrain front-gear dropdown. On the bike drivetrain edit page, choosing one checks and disables the **Internal front gears** checkbox (they have no external option for their chainring count); switching to a standard gear re-enables it. - **e-Scooter wheel sizes** — `6in` (90), `6.5in` (110), `9in` (145) from bikeindex/bike_data#52, in `iso_bsd` sort order (mirrors #3786). - **Balance Bike cycle type** — non-pedal, never-motorized, and drivetrain-less (still a cycle, like unicycle/trailer). Seeds only run on a fresh database, so run these in the production console to add the gear/wheel entries idempotently (the Balance Bike type is code-defined and needs no console action): ```ruby [ {name: "6 Speed Pinion Gearbox", count: 6, internal: true}, {name: "9 Speed Pinion Gearbox", count: 9, internal: true}, {name: "12 Speed Pinion Gearbox", count: 12, internal: true}, {name: "18 Speed Pinion Gearbox", count: 18, internal: true} ].each do |attrs| FrontGearType.find_or_initialize_by(name: attrs[:name]).update!(attrs) end [ {name: "6in", iso_bsd: 90, priority: :uncommon, description: "6in (6 x 1 1/4, 150 x 30) small kick/e-scooters (Uncommon)"}, {name: "6.5in", iso_bsd: 110, priority: :uncommon, description: "6.5in solid tire, Hiboy S2 Lite and hoverboard-style scooters (Uncommon)"}, {name: "9in", iso_bsd: 145, priority: :uncommon, description: "9in (9 x 2) Hiboy S2R Plus and other 9in e-scooters (Uncommon)"} ].each do |attrs| WheelSize.find_or_initialize_by(iso_bsd: attrs[:iso_bsd]).update!(attrs) end ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #50. Adds the three remaining e-scooter tire sizes so they resolve automatically, keyed by ISO BSD and named by the inch size riders use.
6in(BSD 90, 6 x 1 1/4 / 150 x 30 — small kick/e-scooters, e.g. ES1),6.5in(BSD 110, Hiboy S2 Lite and hoverboard-style solid tires), and9in(BSD 145, Hiboy S2R Plus and other 9in e-scooters) rows, inserted iniso_bsdsort order.6in~90 from the 150 x 30 geometry,6.5in~110 for the small solid-tire rim,9in~145 between the8.5in(134) and10in(152) beads. Authoritative ETRTO codes for these scooter tires aren't consistently published, so no ISO code is asserted where unconfirmed.