Update skills and AGENTS.md from Bike Index - #29
Merged
Merged
Conversation
Adds the guidance that carries over to a gem: mise for version management, bin/lint usage (pass changed paths, never revert the linter), full class and module names, pithy comments, composition over include, the Functionable module convention, /pr for pull requests, and subagent model selection. Rails-only material is left out — bin/env and $DEV_PORT, multi-database and AnalyticsRecord, acts_as_paranoid, sortable_search_params, and the whole Stimulus/Tailwind/ViewComponent frontend section. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011yBbeP6HZZkEwWK4jiikTr
skill-creator is deleted. The remaining three are updated from bikeindex/bike_index main, adapted to a gem rather than copied. Two corrections that matter, both in sandbox-test-setup: - The local macOS section said Ruby was managed by rbenv, which isn't installed on this machine at all — `rbenv init` just fails. It's mise, matching .tool-versions, so the fix is a PATH prefix into the mise install dir. - GitHub's archive-tarball endpoint and codeload now 403 through the web sandbox proxy, so the Ruby build clones the tag instead of curl-ing a tarball. The allowed/blocked host list is updated to match. Also adds the Conductor cloud sandbox (Amazon Linux) environment, a scoped-specs section and the same-setup/one-example rule to rspec-testing, and /simplify, base-branch handling, merge-from-base and the tightened body guidance to pr. Rails-only upstream material is left out: request-vs-controller specs, VCR, factory_bot, Sidekiq draining, migration re-dating, translations, and the whole frontend screenshot phase. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011yBbeP6HZZkEwWK4jiikTr
bin/release checked the branch and that it was level with origin/main, but not that the working tree was clean — so a dirty tree would get carried onto the release branch and released. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011yBbeP6HZZkEwWK4jiikTr
It was adapted from the Bike Index skill rather than verified against a real binxtils checkout in that environment, so its dnf package list and mise flow were guesses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011yBbeP6HZZkEwWK4jiikTr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also pull in a small update to
bin/releasethat was missed in #28