Repository navigation
Conversation
Under a user token (e.g. a PAT, including one used inside Actions) the reviewer posts comments as that user, but create() hardcoded botLogin to "github-actions[bot]" whenever GITHUB_ACTIONS=true. So its own prior inline threads came back classified "human", hasUnresolvedBotThreads() was false, and the reconcile/verify follow-up step was skipped. Resolve botLogin from the token via GET /user (correct for user tokens + PATs), falling back to "github-actions[bot]" only when /user 403s (the default Actions App token). Also removes the direct process.env read from github.ts, honoring the "env is read only in loadConfig()" rule. (Also: gitignore the local harness/ subdir.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bilikaz
commented
Jun 9, 2026
bilikaz
left a comment
Owner
Author
There was a problem hiding this comment.
1 informational finding(s) (nits / suggestions, not blocking — listed here as summary, not tracked as individual threads):
src/vcs/github.ts— The barecatchwithoutas anymay trigger TypeScript strict error handling. Consider addingcatch (err: unknown)orcatch (_err: unknown)to satisfy strict TS, though the fallback behavior is …
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bilikaz
commented
Jun 9, 2026
bilikaz
left a comment
Owner
Author
There was a problem hiding this comment.
2 informational finding(s) (nits / suggestions, not blocking — listed here as summary, not tracked as individual threads):
src/vcs/github.ts— Theapprove()method silently returns when no summary is provided. While this matches the described behavior, consider adding a comment or assertion to make this no-op explicit for future maintainer…src/vcs/github.ts— The try-catch aroundclient.users.getAuthenticated()is correct. However, consider catching only specific errors (e.g., 403) rather than all errors, to avoid silently swallowing unexpected failures …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under a user token (e.g. a PAT, including one used inside Actions) the reviewer posts comments as that user, but create() hardcoded botLogin to "github-actions[bot]" whenever GITHUB_ACTIONS=true. So its own prior inline threads came back classified "human", hasUnresolvedBotThreads() was false, and the reconcile/verify follow-up step was skipped.
Resolve botLogin from the token via GET /user (correct for user tokens + PATs), falling back to "github-actions[bot]" only when /user 403s (the default Actions App token). Also removes the direct process.env read from github.ts, honoring the "env is read only in loadConfig()" rule.
(Also: gitignore the local harness/ subdir.)