Repository navigation
Conversation
- vcs/ -> providers/: Provider port, BaseProvider (shared local-git plumbing), LocalProvider/MockProvider naming aligned with adapters; ctx.vcs -> ctx.provider - llm/: client.ts (callLLM + resolveModel) / transport.ts (send + receive, SSE merged in) / types.ts (shared wire + API vocabulary); tools contract in tools/types.ts - stages/shared.ts: prompt assets, SLOT table, base section assembly, LLM stage metrics shared by review/reconcile - single definitions: git wire types (lib/git.ts, port re-exports), isOpenBotThread predicate, summary fragment constants, joinScope - lib/errors.ts errorMessage() replaces all (e as Error) casts - logger contract in logger/types.ts; index.ts is a barrel - REVIEW_DEFAULTS exported; tests build configs from real defaults Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- docs/ARCHITECTURE.md: system map with Mermaid diagrams, module map, core patterns, repo-specific conventions - docs/conventions/: portable rule set (naming, types placement, consolidation, errors, configuration, logging, testing, docs) — reusable across projects - docs/adr/: 13 settled decisions; ADR-0013 adopts the conventions - README: published package name, layered docs, config table fixes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Internal module paths restructured (dist/vcs -> dist/providers, llm files renamed); CLI surface, env vars and behavior unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bilikaz
commented
Jun 10, 2026
bilikaz
left a comment
Owner
Author
There was a problem hiding this comment.
8 informational finding(s) (nits / suggestions, not blocking — listed here as summary, not tracked as individual threads):
src/ctx.ts— The asBool helper is a good addition for consistent boolean parsing. Consider adding a doc comment explaining the accepted values since this is a new public-facing utility.src/providers/base.ts— Good consolidation of git plumbing into BaseProvider. The protected gitCwd field gives subclasses the flexibility to set the working directory while keeping the common diff logic shared.src/llm/client.ts— The new LLMValidationError class is appropriately minimal. Consider adding a doc comment explaining when this error is thrown to aid debugging.src/lib/errors.ts— The errorMessage helper properly handles unknown throws per the error-handling convention. This eliminates the dangerous(e as Error).messagepattern throughout the codebase.src/providers/types.ts— Good centralization of the bot-thread predicate. The type guard signature ensures callers get proper typing after the check. This follows ADR-0011 correctly.src/stages/shared.ts— The shared section assembly functions properly encode the prompt envelope order and presence rules. Stages can still append their specific sections (like thread_decisions) to the returned arrays.README.md— README correctly documents the new local:// provider for console-only review. The explanation of container requirements is clear and important for safety.package.json— Version bump from 0.1.2 to 0.2.0 is appropriate given the breaking changes (provider rename, LLM client restructuring, new docs folder). Consumers will need to update imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.