Add global bash PATH config to mirror fish shell#184
Open
binarypie wants to merge 2 commits into
Open
Conversation
Fish is the default Hypercube shell and sets up the user PATH (~/.local/bin, ~/.cargo/bin, ~/go/bin, ~/.npm-packages/bin) in /etc/fish/config.fish. Bash and other POSIX shells never read that config, so anything launched from them inherited a stripped-down PATH. This broke the ai-dev 'claude'/'agy' wrapper scripts in ~/.local/bin: they exec 'podman', which was not resolvable on the bash PATH. Add /etc/profile.d/hypercube-path.sh, which mirrors the fish PATH additions (and sources ~/.cargo/env when present) for sh/bash login and interactive shells. Also assert the file's presence in the build tests.
The real gap was the standard system directories (/usr/bin, /bin, /usr/sbin, etc.), not the per-user dirs. podman lives at /usr/bin/podman, so when a bash shell came up without /usr/bin on PATH the ai-dev 'claude'/'agy' wrappers could not exec it. Ensure the default system directories are always present (appended if an inherited PATH lacks them, sane even from an empty PATH), while still mirroring the fish per-user PATH additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish is the default Hypercube shell and sets up the user PATH
(~/.local/bin, ~/.cargo/bin, ~/go/bin, ~/.npm-packages/bin) in
/etc/fish/config.fish. Bash and other POSIX shells never read that
config, so anything launched from them inherited a stripped-down PATH.
This broke the ai-dev 'claude'/'agy' wrapper scripts in ~/.local/bin:
they exec 'podman', which was not resolvable on the bash PATH.
Add /etc/profile.d/hypercube-path.sh, which mirrors the fish PATH
additions (and sources ~/.cargo/env when present) for sh/bash login and
interactive shells. Also assert the file's presence in the build tests.