Merged
Conversation
rocka
requested changes
Jun 30, 2025
Contributor
rocka
left a comment
There was a problem hiding this comment.
Generally looks fine, better if remembered DRY (Don't Repeat Yourself)
Contributor
|
Those setting values made me think that maybe we should switch to some centerialized store library, like https://github.com/pmndrs/zustand Instead of passing |
…eclaration of props
Contributor
Author
|
I think now all issues are resolved. Is there anything I can improve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #19 .
WelcomeandDevicebar.WelcomeDeviceBarmd:lg:2xl:provided byunocss.