Reject MUL constraints in M4 verifier reduction#1776
Open
latifkasuli wants to merge 1 commit into
Open
Conversation
jimpo
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the verifier-side M4 reduction reject constraint systems with MUL constraints up front.
The M4 reduction currently handles only AND constraints. The prover already asserts this before proving, but the verifier path still built a zero intmul claim and proceeded. This PR mirrors the prover's scope check on the verifier side, so unsupported circuits fail immediately with the same message instead of reaching the shift verifier indirectly.
Test plan
cargo test -p binius-m4-prover --lib reduction::tests::verifier_rejects_mul_constraints_before_reading_transcript -- --exactcargo test -p binius-m4-prover --lib reduction::testscargo test -p binius-m4-prover --libcargo test -p binius-m4-verifier --libcargo +nightly-2026-01-01 fmt --checkcargo clippy -p binius-m4-prover -p binius-m4-verifier --all-features --tests --benches -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc -p binius-m4-prover -p binius-m4-verifier --all-features --document-private-items --no-deps