Replace lazy loading of vectorize_counts_and_tree#115
Closed
RMeneses99 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@RMeneses99 just realized you fixed this before me! Thank you!!! Fixed in the other PR. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_vectorize_counts_and_treewas a private scikit-bio API that was promotedto public as
vectorize_counts_and_treein scikit-bio >= 0.6. The top-levelimport of the old private name broke all gemelli imports on modern scikit-bio
versions, even for users who never use phylogenetic methods.
Fix
fast_unifrac()where it is actually usedFixes #112