Skip to content
This repository was archived by the owner on Jul 29, 2020. It is now read-only.

added a function to retrieve the environment type for a barcode#165

Open
sjanssen2 wants to merge 11 commits intobiocore:masterfrom
sjanssen2:display_barcode_environment
Open

added a function to retrieve the environment type for a barcode#165
sjanssen2 wants to merge 11 commits intobiocore:masterfrom
sjanssen2:display_barcode_environment

Conversation

@sjanssen2
Copy link
Copy Markdown
Collaborator

It is now displayed when a barcode get scanned. See issue #158

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 91.484% when pulling 9d5ffac on sjanssen2:display_barcode_environment into 19fa479 on biocore:master.

Comment thread knimin/lib/data_access.py Outdated
self._con.execute(sql, [tuple(barcodes)])

def get_barcode_environment_types(self, barcode):
# TODO: write test code once test data have been dumped into DB!
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you prefer holding this pr until this is resolved?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on the timing of the DB dump. I don't want to wait for weeks with further development.

…ssen2/labadmin into display_barcode_environment

Conflicts:
	knimin/lib/data_access.py
	knimin/lib/tests/test_data_access.py
	knimin/lib/tests/test_util.py
	knimin/tests/test_ag_pulldown.py
	knimin/tests/test_barcode_util.py
# animal barcodes
barcode = '000002012'
exp = [u'Animal(Dog)']
exp = [u'Human']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the host for this sample changed...?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants