This repository was archived by the owner on Jul 29, 2020. It is now read-only.
Add logging for qiita pushing#255
Open
wasade wants to merge 10 commits intobiocore:masterfrom
Open
Conversation
Propose we remove this TODO, as it's already been discussed in mail
Logging for all methods within PushQiitaHandler has been added.
Local testing confirms marking SQL statement is not raising an Error. Speculating whether there needs to be time between the POST, and the immediate call afterward to the database directly.
Locally, I can see the value for the sample ID are changing from N to Y, however, this unittest continues to fail. Increasing the wait time, or perhaps ensuring a commit occurs will change the result.
As requested by Daniel. Confirm or deny an exception is going unseen
wasade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the exploration from @charles-cowart on #254, and also includes the last few tweaks that appeared necessary on the communication to qiita-rc