Fixed queue issue

[rishitha-ravi]

No description provided.

[arunasd463]

can name this as sql just to maintain uniformity.

[arunasd463]

do we need info in dao functions? we already have this in error.

[arunasd463]

same changes needed like getDocumentIdsByTaxonConceptIds.

[arunasd463]

info not needed.

[arunasd463]

can avoid this info.

[arunasd463]

do we need this info.

[arunasd463]

consult this with @thomvee.Both will execute if both becomes true.

[arunasd463]

return early if no documents is found

[arunasd463]

this logic can be improved using set because it performs same action. please refer

public void handleTaxonByName(TaxonomyUpdateData updateData) {
        if (updateData == null) return;

        // 1. Accumulate all unique Taxon IDs that need processing across all scenarios
        Set<Long> taxonIdsToProcess = new HashSet<>();

        if (updateData.getBulkIds() != null) {
            taxonIdsToProcess.addAll(updateData.getBulkIds());
        }

        if (updateData.getDeleteRecoIds() != null) {
            taxonIdsToProcess.addAll(updateData.getDeleteRecoIds());
        }

        if (!Objects.equals(updateData.getOldName(), updateData.getName()) && updateData.getTargetId() != null) {
            taxonIdsToProcess.add(updateData.getTargetId());
        }

        // 2. Early exit if there is absolutely nothing to process
        if (taxonIdsToProcess.isEmpty()) {
            return;
        }

        // 3. Delegate to a single, optimized processing pipeline
        processDocumentsForTaxonIds(taxonIdsToProcess);
    }

    private void processDocumentsForTaxonIds(Set<Long> taxonIds) {
        try {
            // Fetch all associated document IDs in one single database call
            List<Long> documentIds = docSciNameDao.getDocumentIdsByTaxonConceptIds(new ArrayList<>(taxonIds));
            if (documentIds == null || documentIds.isEmpty()) {
                logger.info("No documents found for the requested taxon updates.");
                return;
            }

            // Fetch all Document objects in bulk
            List<Document> documents = documentDao.findByBulkIds(documentIds);
            
            // Local Cache Map to avoid hitting the resource API repeatedly for duplicate uFileIds
            Map<String, UFile> uFileCache = new HashMap<>();

            for (Document doc : documents) {
                try {
                    UFile resource = null;
                    
                    if (doc.getuFileId() != null) {
                        String uFileIdStr = doc.getuFileId().toString();
                        
                        // Look up in the local cache first before making an API call
                        if (uFileCache.containsKey(uFileIdStr)) {
                            resource = uFileCache.get(uFileIdStr);
                        } else {
                            logger.debug("Fetching resource from service for uFileId: {}", uFileIdStr);
                            resource = resourceService.getUFilePath(uFileIdStr);
                            
                            if (resource != null && resource.getPath() != null) {
                                resource.setPath(resource.getPath().replace("/documents", ""));
                            }
                            // Save to local cache (even if null, to avoid repeating a failing/empty request)
                            uFileCache.put(uFileIdStr, resource);
                        }
                    }

                    // Process the scientific names extraction safely
                    updateScientificNames(doc.getId(), resource, doc.getExternalUrl());

                } catch (com.strandls.resource.ApiException e) {
                    logger.error("API error fetching resource for documentId: {} (uFileId: {}). Skipping.", 
                            doc.getId(), doc.getuFileId(), e);
                } catch (Exception e) {
                    logger.error("Unexpected error processing documentId: {}. Skipping.", doc.getId(), e);
                }
            }
        } catch (Exception e) {
            logger.error("Critical error while batch processing taxonomy documents", e);
        }
    }

[arunasd463]

Please check my comments and update the code.