Skip to content

Fix: Better error messages in Document Embedding widget#1122

Closed
leskovecg wants to merge 1 commit into
masterfrom
fix/embedder-connection-tests
Closed

Fix: Better error messages in Document Embedding widget#1122
leskovecg wants to merge 1 commit into
masterfrom
fix/embedder-connection-tests

Conversation

@leskovecg

Copy link
Copy Markdown
Collaborator

Issue

Fixes #1109 – Improves the error handling in the Document Embedding widget when there is no internet connection or when the server is not responding.


Description of changes

  • Added pre-check for internet and server availability before making a request.
  • Separated error messages for:
    • No internet connection
    • Invalid or unresponsive server

Includes

  • Code changes
  • Tests
  • Documentation

@ajdapretnar

Copy link
Copy Markdown
Collaborator

This PR has numerous failed tests, mostly resulting from changes in the widget. Please run tox -e pyto test the entire environment and resolve the issues related to your PR.

@@ -0,0 +1,72 @@
import pytest

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot import pytest as pytest is not a dependency of Orange.

@ajdapretnar

Copy link
Copy Markdown
Collaborator

Closed in favour of #1133.

@ajdapretnar ajdapretnar closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document Embedding: Improve error message

3 participants