Create Corpus: skip empty documents#1130
Open
leskovecg wants to merge 1 commit into
Open
Conversation
3 tasks
leskovecg
force-pushed
the
fix-skip-empty-documents
branch
from
c01e8e8 to
0eea60f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1104 — Create Corpus widget should not output completely empty documents.
Description of changes
This PR updates the
commit()method in theCreate Corpuswidget to filter out documents with empty text (""or whitespace). Only documents with non-empty content are sent to the output.If no valid documents remain, the widget sends
Noneinstead of an empty corpus.Changes
commit()logic updated to skip empty documents"?") preserved if missingtest_output_skips_empty_documentsupdated accordinglyIncludes