Implement configurable vote limit to exclude screenshots after N votes - #65
Merged
Conversation
Co-authored-by: IvoLeist <28399610+IvoLeist@users.noreply.github.com>
Co-authored-by: IvoLeist <28399610+IvoLeist@users.noreply.github.com>
Co-authored-by: IvoLeist <28399610+IvoLeist@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Modify voting logic for screenshots removal
Implement configurable vote limit to exclude screenshots after N votes
Jan 7, 2026
…iomedicalGenomicsCNAG/ShinyImageVoteR into copilot/modify-screenshot-voting-logic
IvoLeist
marked this pull request as ready for review
January 14, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots should be removed from the voting queue once they reach a threshold number of votes across all users.
Changes
Voting logic (
R/mod_voting.R): Added check inget_mutation()to skip screenshots wherevote_count_total >= max_votes_per_screenshot. When all remaining screenshots exceed the limit, returns "done" state.Configuration (
config.yamlfiles): Addedmax_votes_per_screenshot: 3parameter with fallback default. Applied to all three config files (default template, runtime, test).Tests (
test-voting-module.R): Added two tests covering partial skipping (some screenshots at limit) and complete skipping (all at limit). Tests setvote_count_totaldirectly rather than relying on trigger behavior.Implementation
URL-based navigation (back button) unchanged—users can still review their previous votes regardless of current vote totals.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.