Fix unconfigured voting options being skipped at 3 votes

[Copilot]

Voting options not present in voting_options_max_matching_votes were being skipped with a default limit of 3 votes. For example, none_of_above was skipped even though only yes, diff_var, and germline were configured with limits.

Changes

R/mod_voting.R

• Changed NULL/NA max_votes handling from defaulting to 3 to skipping the limit check entirely via next

# Before: applied 3-vote limit to unconfigured options
if (is.null(max_votes) || is.na(max_votes)) {
  max_votes <- 3
}

# After: no limit for unconfigured options
if (is.null(max_votes) || is.na(max_votes)) {
  print(paste("Skipping limit check for option:", option_key))
  next
}

tests/testthat/test-voting-module.R

• Added test verifying unconfigured options are never skipped regardless of vote count
• Added test verifying configured options still skip correctly at their limit
• Parameterized all SQL queries

Result

• Options in voting_options_max_matching_votes: Limited as configured
• Options not in voting_options_max_matching_votes: No limit applied

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Matching votes skipping unexpectedly triggered for a category not present in config "voting_options_max_matching_votes"</issue_title>
<issue_description>Observed:
Skipping got triggered for the option none_of_above (see below)

coordinates REF ALT agreement observation comment shinyauthr_session_id time_till_vote_casted_in_seconds
chr11:110816223 AG A skipped - max matching votes (3) for option (none_of_above) reached NA NA X4INbEVKBRtJUtAmJ1ac9mJ3ygNZkTDyH9gfvC3pibxeqM2371wdtvroOfTYaucR NA

Even though it is not set inside the config

voting_options_max_matching_votes:
  'yes': 9
  diff_var : 9
  germline: 9

Expected:
The options which are not inside voting_options_max_matching_votes should not have any matching votes limit.
-> Should never be skipped</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Matching votes skipping unexpectedly triggered for a category not present in config "voting_options_max_matching_votes" #71

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.