Migrate to standard Go modules (go.{mod,sum}) from Gopkg, update Thrift service definitions#47
Open
kenshaw wants to merge 1 commit intobippio:masterfrom
Open
Migrate to standard Go modules (go.{mod,sum}) from Gopkg, update Thrift service definitions#47kenshaw wants to merge 1 commit intobippio:masterfrom
kenshaw wants to merge 1 commit intobippio:masterfrom
Conversation
…ft service definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the driver to use standard Go modules, and the Thrift service definitions.
usql has had this driver in its code base for some time, but it has not been working properly. I'd like to reenable this driver for default release builds, but cannot do so until the issue with the API changes have been rectified, as other drivers that usql uses also make use of Thrift.
Appreciate the work you've done on making this driver available to the community!