update nginx to version 1.31.1#710
Open
mishaschwartz wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
documentation
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4308/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : bump-nginx DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca
|
Member
|
run tests |
fmigneault
reviewed
Jun 2, 2026
Member
fmigneault
left a comment
fmigneault
left a comment
There was a problem hiding this comment.
Looks good by itself,
Waiting on the re-triggered CI tests to check if failure was sporadic or an actual problem.
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4315/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : bump-nginx DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca
|
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4318/Result 🆘 ABORTEDBIRDHOUSE_DEPLOY_BRANCH : bump-nginx DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : false PAVICS_HOST : https://host-140-133.rdext.crim.ca
|
Member
|
@mishaschwartz Running on current https://github.com/bird-house/birdhouse-deploy/tree/master works on the CI. Proxy image shows this error: |
fmigneault
requested changes
Jun 2, 2026
Member
fmigneault
left a comment
fmigneault
left a comment
There was a problem hiding this comment.
Investigate why it breaks with ssl.
Collaborator
Author
|
Yes please hold off on this for a minute. There are a few syntax changes that I was going to push yesterday but time got away from me. I'll be able to update that tomorrow |
tlvu
reviewed
Jun 3, 2026
|
|
||
| # Public (on the internet) fully qualified domain name of this Birdhouse | ||
| # Set this to "on" to enable http2 for port 443 | ||
| #export PROXY_HTTP2_ON_OFF=off |
Collaborator
There was a problem hiding this comment.
Oh this is a backward incompatible change !
We are currently activating http2 via PROXY_LISTEN_443_PARAMS but how this needs to be PROXY_HTTP2_ON_OFF=on?
Please update the changelog clearly with the specific config change and note it is backward incompatible.
tlvu
requested changes
Jun 3, 2026
Collaborator
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/4325/Result ❌ FAILUREBIRDHOUSE_DEPLOY_BRANCH : bump-nginx DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-118.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/847/NOTEBOOK TEST RESULTS |
fmigneault
approved these changes
Jun 3, 2026
Member
fmigneault
left a comment
fmigneault
left a comment
There was a problem hiding this comment.
Thanks for the broken nginx investigation. All good 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This update includes:
ssl on;directive is no longer supported (replaced withlisten 443 ssl;)listen 443 http2directive is no longer supported (replaced withhttp2 on;)Changes
Non-breaking changes
Breaking changes
Related Issue / Discussion
Additional Information
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false