Skip to content

RFC: properly implement url parsing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neutrinoceros wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

RFC: properly implement url parsing #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dsharp_opac/dsharp_opac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import sys
import warnings
from contextlib import contextmanager
from urllib.parse import urlsplit
import socket
from importlib.resources import files
import astropy.constants as const
Expand Down Expand Up @@ -205,7 +206,7 @@ def download(packagedir):
data = json.load(f)
for material, link in data.items():

filename = link.split('/')[-1]
filename = urlsplit(link).path

print('material: {}, downloading {}: ... '.format(
material, filename), end='')
Expand Down