Fix color order for NEON decoding - #121
Open
clydebarrow wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect channel ordering in the ARM NEON fast-path so RGB8888 output matches other architectures (addresses #120 on Apple Silicon / ARM).
Changes:
- Corrects the NEON
vst4_u8channel packing for RGB8888 so output is written as RGBA (byte order R, G, B, A). - Applies the fix consistently across all four 8-pixel stores within
JPEGPutMCU22().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120
Decoding on ARM NEON now produces the same results as other architectures.