ci: adopt the golden CI floor — nothing was running verify - #1
Merged
Conversation
The repo shipped with a `verify` script and no workflow, so nothing ran it on push or PR. The fleet's conformance checker caught it on its first sweep, which is a fair result for a package published an hour earlier and a reminder that the gap is never 'no gate' — it is a gate nobody wired up. `npm test` here also exercises the package's `exports` map, because the tests import it BY NAME rather than reaching into dist/. A broken exports or files list therefore fails here rather than at the first consumer's install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo shipped with a
verifyscript and no workflow, so nothing ran it on push or PR.The fleet's new conformance checker caught it on its first sweep — a fair result for a package published an hour earlier, and a reminder that the gap is never "no gate", it is a gate nobody wired up.
npm testhere also exercises the package'sexportsmap, because the tests import it by name rather than reaching intodist/. A brokenexportsorfileslist therefore fails here rather than at the first consumer's install.Found by
dotfiles/scripts/ci/check-verify-contract.sh(bitbaum/dotfiles#16).🤖 Generated with Claude Code