chore: declare Node once, in .nvmrc - #125
Merged
Merged
Conversation
CI and the deploy pipeline each picked their own Node major, so a build could ship from a toolchain CI never verified — npm 10 and 11 disagree about optional platform deps, which failed 'npm ci' on a lockfile the other npm wrote. One declaration both sides read. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and the deploy pipeline each picked their own Node major, so a build could ship from a toolchain CI never verified. npm 10 and 11 disagree about optional platform deps — a lockfile written by one reads as "out of sync" to the other, which is exactly how hirnli's deploy failed
npm ciwhile its CI was green.Adds
.nvmrcand points the CI workflow atnode-version-file, so the version is declared once and both sides read it.