fix(ci): remove an input the reusable deploy workflow does not accept - #126
Merged
Conversation
The .nvmrc change rewrote every 'node-version:' in .github/workflows, including the one in this shim — but that line was an INPUT to the shared deploy workflow, not a setup-node arg. An undeclared input makes the workflow invalid, and GitHub reports startup_failure: a deploy that never ran, rendered as a red X with no logs. The shared workflow reads .nvmrc itself now, so the shim needs nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
botsmann's deploy came back as
startup_failure— GitHub could not start the workflow at all, so there are no logs, just a red X.Cause: the
.nvmrcchange rewrote everynode-version:line under.github/workflows/, and this shim had one — but there it was an input to the reusable deploy workflow, not asetup-nodeargument. Rewriting it tonode-version-file:created an input the reusable workflow does not declare, which makes the calling workflow invalid.The shared pipeline reads
.nvmrcfrom the repo itself now, so the shim needs no Node input at all. botsmann's.nvmrcis already 22, matching its CI.