ci: call the verify SSOT instead of hand-copying it with --if-present - #134
Closed
catomean wants to merge 1 commit into
Closed
ci: call the verify SSOT instead of hand-copying it with --if-present#134catomean wants to merge 1 commit into
catomean wants to merge 1 commit into
Conversation
CI listed format:check, lint, test and build as four separate steps — the same four `npm run verify` already runs — and put `--if-present` on each of them. That combination is the 'gate that cannot go red' shape. `--if-present` turns a missing script into a PASS, so renaming or deleting any of those scripts would have left CI green while the check silently stopped running. And a hand-copied list drifts from `verify` the moment `verify` changes, which is how a repo ends up with a local gate and a CI gate that are two different things, only one of which blocks a merge. CI now runs `npm run verify` verbatim: one definition of verified, enforced identically on a laptop and on the branch. Found by dotfiles/scripts/ci/check-verify-contract.sh. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
Closing as redundant — #133 already landed exactly this change on Worth recording why the duplicate happened: the sweep that found it audited local working trees under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI listed
format:check,lint,testandbuildas four separate steps — the same fournpm run verifyalready runs — with--if-presenton each.That combination is the gate that cannot go red.
--if-presentturns a missing script into a pass, so renaming or deleting any of those scripts would have left CI green while the check silently stopped running. And a hand-copied list drifts fromverifythe momentverifychanges — leaving a local gate and a CI gate that are two different things, only one of which blocks a merge.CI now runs
npm run verifyverbatim: one definition of verified, enforced identically on a laptop and on the branch.Found by
dotfiles/scripts/ci/check-verify-contract.sh(bitbaum/dotfiles#16), which now enforces this contract across the fleet.🤖 Generated with Claude Code