Skip to content

ci: call the verify SSOT instead of hand-copying it with --if-present - #134

Closed
catomean wants to merge 1 commit into
mainfrom
ci/call-verify-ssot
Closed

ci: call the verify SSOT instead of hand-copying it with --if-present#134
catomean wants to merge 1 commit into
mainfrom
ci/call-verify-ssot

Conversation

@catomean

Copy link
Copy Markdown
Collaborator

CI listed format:check, lint, test and build as four separate steps — the same four npm run verify already runs — with --if-present on each.

That combination is the gate that cannot go red. --if-present turns a missing script into a pass, so renaming or deleting any of those scripts would have left CI green while the check silently stopped running. And a hand-copied list drifts from verify the moment verify changes — leaving a local gate and a CI gate that are two different things, only one of which blocks a merge.

CI now runs npm run verify verbatim: one definition of verified, enforced identically on a laptop and on the branch.

Found by dotfiles/scripts/ci/check-verify-contract.sh (bitbaum/dotfiles#16), which now enforces this contract across the fleet.

🤖 Generated with Claude Code

CI listed format:check, lint, test and build as four separate steps — the same
four `npm run verify` already runs — and put `--if-present` on each of them.

That combination is the 'gate that cannot go red' shape. `--if-present` turns a
missing script into a PASS, so renaming or deleting any of those scripts would
have left CI green while the check silently stopped running. And a hand-copied
list drifts from `verify` the moment `verify` changes, which is how a repo ends
up with a local gate and a CI gate that are two different things, only one of
which blocks a merge.

CI now runs `npm run verify` verbatim: one definition of verified, enforced
identically on a laptop and on the branch.

Found by dotfiles/scripts/ci/check-verify-contract.sh.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@catomean

Copy link
Copy Markdown
Collaborator Author

Closing as redundant — #133 already landed exactly this change on main ('ci: make the verify job actually run verify'), and this PR was cut from a stale local checkout that predated it.

Worth recording why the duplicate happened: the sweep that found it audited local working trees under ~/dev, which drift. The fleet audit reads each repo's own default branch remotely, and correctly shows botsmann as conforming. Local-tree auditing is the inferior design and has been dropped.

@catomean catomean closed this Aug 16, 2026
@catomean
catomean deleted the ci/call-verify-ssot branch August 16, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant