fix(nav): the current page was coloured, never announced - #167
Merged
Conversation
`isActive` already decided the link's colour and set no aria-current, so the current page existed only for people who can see it. Zero occurrences of aria-current anywhere in this codebase. The megamenu trigger is untouched: it is a disclosure button, not a link to a page, and Popover.Button already announces aria-expanded/aria-haspopup itself. No visual change. Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isActivealready decided the link's colour and set noaria-current— the current page existed only for people who can see it. Zero occurrences ofaria-currentanywhere in this codebase.The megamenu trigger is untouched: it's a disclosure button, not a link to a page, and
Popover.Buttonalready announcesaria-expanded/aria-haspopupitself.No visual change.
Verification
tsc --noEmitshows 3 pre-existing errors (missingvitesttypes after the recent jest→vitest migration, confirmed unrelated by diffing with/without this change — identical count both ways). Lint clean.Found by the fleet nav-contract audit, which flags a repo whose navigation computes an active state and never announces it anywhere.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE