chore(deps): sitekit v0.2.0 → v0.3.0, for a fix this repo could not make - #15
Merged
Conversation
…make v0.3.0 raises the shared nav links to the 44px touch floor (they were px-2 py-1 on text-xs, roughly a 28px target) and gives them and the wordmark a focus-visible ring — the package previously defined no focus style at all. Both defects were unfixable here: a consumer cannot patch markup it does not own. This site is currently masked from the worst of it by having only three nav items, which is a reason it went unnoticed, not a reason it was fine. The masthead does not get taller. The row pays for the bigger targets out of its own padding (py-4 -> py-2), asserted by a test in the package. Lockfile edited by hand rather than regenerated: `resolved` keeps the SSH scheme the lockfile already used, and letting npm rewrite it would record this machine's git setup instead of the dependency. Verified by installing from the edited lockfile and reading the version back out of node_modules. verify green: format, typecheck, lint, 4 tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.3.0 raises the shared nav links to the 44px touch floor (they were
px-2 py-1ontext-xs— roughly a 28px target) and gives them and the wordmark afocus-visiblering. The package previously defined no focus style at all.Both defects were unfixable here — a consumer cannot patch markup it does not own.
This site is currently masked from the worst of it by having only three nav items. That's a reason it went unnoticed, not a reason it was fine.
The masthead does not get taller: the row pays for the bigger targets out of its own padding (
py-4→py-2), asserted by a test in the package.On the lockfile
Edited by hand rather than regenerated.
resolvedkeeps the SSH scheme the lockfile already used — lettingnpm installrewrite it records this machine's git setup rather than the dependency. Verified by installing from the edited lockfile and reading the version back out ofnode_modules.Verification
npm run verifygreen: format, typecheck, lint, 4 tests.Follows bitbaum/sitekit#8. Sibling bump: bitbaum/substrata#12 — the two consumers were drifted from each other (v0.1.1 vs v0.2.0) as well as from the fix, and now land on the same version.
Minor, not fixed here:
tsconfig.tsbuildinfois tracked in git and changes on every typecheck. It's a build artifact and probably belongs in.gitignore.🤖 Generated with Claude Code
https://claude.ai/code/session_01XeELB8b3N4JrT2asYL9WvE