Skip to content

fix(ci): put the build back in verify - #205

Merged
catomean merged 1 commit into
mainfrom
fix/verify-runs-build
Aug 4, 2026
Merged

fix(ci): put the build back in verify#205
catomean merged 1 commit into
mainfrom
fix/verify-runs-build

Conversation

@catomean

@catomean catomean commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Closes #202.

Why

verify was lint && tsc --noEmit. The cost of that gap is on record: contentlayer 0.3.1 reaches into a React internal React 19 removed, so /blog/[slug] threw d.getOwner is not a function during prerender. Both gated signals stayed green and production served a stale build for weeks while every CI run reported success.

The build breakage itself was fixed in 212213c and deployed 2026-08-04 04:53 — /blog and /blog/intake-engine both return 200. So the fix is in, and this is the class fix landing behind it (deliberately in that order: adding the gate first would only have painted main red).

What

  • verify = lint && typecheck && build
  • typecheck promoted to its own named script, so the chain reads as three steps instead of an inline cd frontend && npx tsc
  • ci.yml and CLAUDE.md comments corrected — the header claimed build was gated while the step comment said it was deferred

The deferral reason no longer holds

The build was deferred on prisma generate failing in CI with a missing query_engine_bg.postgresql.wasm. On prisma 6.19.3 npx prisma generate exits 0.

Honesty about local verification

I could not run the full build locally: it needs Node 18 (.nvmrc — contentlayer crashes on exit under Node 20+) and this machine only has Node 22. CI is the first real execution of this gate. If it goes red, the correct response is to revert this and reopen #202 rather than weaken the gate.

… a broken build

verify was lint + typecheck only. The cost of that gap is on record: contentlayer
0.3.1 reaches into a React internal React 19 removed, so /blog/[slug] threw
"d.getOwner is not a function" during prerender. Both gated signals stayed green
and production served a stale build while every CI run reported success (#202).

verify is now lint + typecheck + build, with `typecheck` promoted to its own
named script so the chain reads as three steps instead of an inline `cd`.

The prisma-engine problem that justified deferring the build no longer
reproduces: `prisma generate` succeeds on 6.19.3.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@catomean
catomean merged commit 250f1b0 into main Aug 4, 2026
2 checks passed
@catomean
catomean deleted the fix/verify-runs-build branch August 4, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blog build is broken: contentlayer 0.3.1 is incompatible with React 19

1 participant