fix(ci): put the build back in verify - #205
Merged
Merged
Conversation
… a broken build verify was lint + typecheck only. The cost of that gap is on record: contentlayer 0.3.1 reaches into a React internal React 19 removed, so /blog/[slug] threw "d.getOwner is not a function" during prerender. Both gated signals stayed green and production served a stale build while every CI run reported success (#202). verify is now lint + typecheck + build, with `typecheck` promoted to its own named script so the chain reads as three steps instead of an inline `cd`. The prisma-engine problem that justified deferring the build no longer reproduces: `prisma generate` succeeds on 6.19.3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202.
Why
verifywaslint && tsc --noEmit. The cost of that gap is on record: contentlayer 0.3.1 reaches into a React internal React 19 removed, so/blog/[slug]threwd.getOwner is not a functionduring prerender. Both gated signals stayed green and production served a stale build for weeks while every CI run reported success.The build breakage itself was fixed in 212213c and deployed 2026-08-04 04:53 —
/blogand/blog/intake-engineboth return 200. So the fix is in, and this is the class fix landing behind it (deliberately in that order: adding the gate first would only have painted main red).What
verify=lint && typecheck && buildtypecheckpromoted to its own named script, so the chain reads as three steps instead of an inlinecd frontend && npx tscThe deferral reason no longer holds
The build was deferred on
prisma generatefailing in CI with a missingquery_engine_bg.postgresql.wasm. On prisma 6.19.3npx prisma generateexits 0.Honesty about local verification
I could not run the full build locally: it needs Node 18 (
.nvmrc— contentlayer crashes on exit under Node 20+) and this machine only has Node 22. CI is the first real execution of this gate. If it goes red, the correct response is to revert this and reopen #202 rather than weaken the gate.