ci(umlauts): enforce lint:umlauts gate in CI and pre-deploy - #255
Merged
Conversation
The Swiss umlaut convention (display text keeps ä/ö/ü; only code identifiers/slugs may use ASCII ue/oe/ae) was enforced only when someone ran `npm run lint:umlauts` by hand. Wire it into the CI quality job and the pre-deploy checks so the class of bug is gated on every PR, push, and deploy instead of relying on memory. Gate currently passes clean (exit 0), so no behavior change today. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
catomean
marked this pull request as ready for review
July 28, 2026 11:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the existing
npm run lint:umlautscheck into:ci.yml—qualityjob, right after ESLint (runs on every PR + push to main)deploy-selfhost.yml— pre-deploy checks, alongside the existing lint/typecheck/i18n gatesWhy
The Swiss umlaut convention — display text keeps
ä/ö/ü; only code identifiers, slugs, and URL anchors may use ASCIIue/oe/ae(documented inscripts/lint-umlauts.sh) — was enforced only when someone ran the script by hand. That's knowledge-in-a-head, not a gate. This closes the class: afuer/prueft/zurueckslipping into user-facing text now fails CI instead of shipping.Risk
None today — the gate passes clean (
exit 0) on currentsrc/, so this is purely additive and changes no behavior. YAML validated for both workflows.🤖 Generated with Claude Code