deps: lucide-react 0.488 -> 1.28 (replace dropped brand icons) - #273
Merged
Conversation
Dependabot's bump (#263) could not go green on its own: lucide v1 removes brand icons, and two were in use. Github -> GitBranch ("view source" link on a project's repoUrl) Chrome -> Compass (the Chrome/Edge row of the browser comparison) Compass rather than Globe because Globe is already the icon for the Firefox/Brave row directly above it — reusing it would have collapsed the open-source/proprietary distinction the comparison exists to draw. Verified: typecheck clean (it enumerates every icon export, so any other removed glyph would have surfaced here), lint 48 warnings / 0 errors — the same count as main, so no new debt. Supersedes #263. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #263, which could not go green on its own: lucide v1 removes brand icons and two were in use, so dependabot's version-only bump failed typecheck.
Changes
GithubGitBranchrepoUrlChromeCompassCompassrather thanGlobebecauseGlobeis already the icon on the Firefox/Brave row directly above it — reusing it would have collapsed the open-source vs proprietary distinction that comparison exists to draw.Verification
npm run typecheck— clean. This is the meaningful check: it enumerates every icon export in use, so any other glyph dropped in v1 would have failed here. Only these two did.npm run lint— 48 warnings, 0 errors: the same count as main, so the bump adds no new lint debt.Build runs in CI.
🤖 Generated with Claude Code