fix(timeline): likes, dislikes, replies, deleting and quoting were all dead

[catomean]

Reported as separate complaints. Nearly all of them are one cause.

Nineteen functions reference something that does not exist

plpgsql only plans a statement when it runs, so each raised 42703 the moment a user triggered it and at no other time. Every one looked healthy — defined, listed by \df, routed by PostgREST, called happily by the app. Nine are the timeline:

Function	Your symptom
like_/unlike_timeline_event	likes don't work
dislike_/undislike_timeline_event	dislikes don't work
add_/delete_timeline_comment	replies
soft_delete_timeline_event	deletion doesn't work
create_quote_reply	reposts

The reaction functions end with UPDATE timeline_events SET like_count = … under a comment reading "if column exists". It doesn't, and never has — counts live in timeline_event_stats, which the line above already updates correctly. A function body is one transaction, so the raise rolled back the INSERT three lines earlier: the like was written, then unwritten. The UI applied its optimistic update, saw success:false and rolled back — which is why the heart fills for ~150ms and empties.

soft_delete_timeline_event checked profiles.user_id/role; neither column exists. And even fixed it would not have worked — it set only deleted_at while every read path filters is_deleted. Production agrees nothing ever took this path: 102 events have both flags, zero have deleted_at alone.

create_quote_reply failed three ways, each hidden behind the last, and never wrote description — the field PostContent renders — so a quote reply would have shown as an empty post.

Found by clicking Like in production and reading the response: HTTP 400, 42703. Proven by rehearsing each against production inside a transaction and rolling back: like returns 1 and lands in stats, delete returns true and the row is genuinely hidden, a quote reply creates with a body and notifies its author.

The gate

Nineteen is not bad luck. plpgsql_check reads every body against the live schema; exposed as count_broken_plpgsql_functions() and ratcheted at the 11 that remain. Its limits are stated where it's defined: static only, so a NOT NULL left unset or a CHECK violation still fails at runtime — both of which create_quote_reply also did.

Nothing else could have caught these: unit tests mock the DB, check-rpc-exists proves a function is defined (all nineteen were), and migration replay never validates a body.

Ctrl+Enter

Same shape — it worked and looked like it didn't. The post was created; the composer kept the text, because the sync effect bails whenever the editor is the active element, which it always is right after a keystroke. So you press again and the server rejects it as a duplicate. Clicking the button never showed this, because a click moves focus to the button first. A reset to empty is now exempt: there is nothing to clobber. Pinned by a test, proven by mutation.

UI, following X

• Action row: five near-identical JSX blocks that had already drifted (one had -ml-2, some had titles, the reply count was an inline three-way IIFE) → one config-driven component. Counts render into a fixed-width tabular slot instead of collapsing to '' at zero, so liking no longer reflows the row and slides every later icon under the cursor that just clicked.
• Edit post: Save moves to the bottom right, beside the character count that decides whether it's allowed.
• Repost: the quoted post now sits directly under what you're writing, buttons last; the textarea loses its border, since the dialog is already the container.

🤖 Generated with Claude Code

https://claude.ai/code/session_012dpTLxh5GJWeWTF1UEvcD5