fix(meta): make the social preview actually resolve - #11
Merged
Conversation
metadataBase was hardcoded to https://printcraft.app, which does not serve this app. The generated card was therefore advertised as https://printcraft.app/opengraph-image and returned 404, so every shared link rendered as a blank rectangle even though the site does generate a real image. Now reads NEXT_PUBLIC_SITE_URL with the actual serving host as the fallback. Applied to both app/src/app/layout.tsx (the tree CI builds) and the identical copy at src/app/layout.tsx, so the stale duplicate cannot re-introduce the dead domain for whoever reads it next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every link to this site shares as a blank rectangle, even though the app does generate a real card.
metadataBasewas hardcoded tohttps://printcraft.app, which does not serve this app — so the card was advertised ashttps://printcraft.app/opengraph-imageand returned 404 (verified live).Now reads
NEXT_PUBLIC_SITE_URLwith the actual serving host as fallback. Applied to bothapp/src/app/layout.tsx(the tree CI builds, perworking-directory: app) and its byte-identical copy atsrc/app/layout.tsx, so the stale duplicate cannot re-introduce the dead domain.Part of a fleet-wide sweep — 10 of 15 sites shared blank, found by FleetCrown Atlas.