Skip to content

fix(nav): the app knew which page you were on and never said it #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Aug 31, 2026
Merged

fix(nav): the app knew which page you were on and never said it #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions app/src/components/layout/AppShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,14 @@ export function AppShell({ children }: { children: ReactNode }) {
<Link
key={link.href}
href={link.href}
// The comparison below already knows which link is the page you
// are on; it only painted it. Announce it too, or the highlight
// exists solely for people who can see it.
aria-current={pathname === link.href ? 'page' : undefined}
className={cn(
'px-4 py-2 text-sm font-medium rounded-full transition-colors',
// min-h-11 is the 44px touch floor. py-2 on text-sm came out
// near 36px, which is a fiddly target on a phone.
'inline-flex min-h-11 items-center px-4 py-2 text-sm font-medium rounded-full transition-colors',
pathname === link.href
? 'text-foreground'
: 'text-muted-foreground hover:text-foreground',
Expand Down Expand Up @@ -129,7 +135,11 @@ export function AppShell({ children }: { children: ReactNode }) {
<Button
variant="ghost"
size="sm"
className="md:hidden h-10 w-10 p-0"
// h-10 w-10 was 40px — under the 44px floor, on the one control a
// phone user must hit to reach any other page.
className="md:hidden h-11 w-11 p-0"
aria-label={mobileMenuOpen ? 'Close menu' : 'Open menu'}
aria-expanded={mobileMenuOpen}
onClick={() => setMobileMenuOpen(!mobileMenuOpen)}
>
{mobileMenuOpen ? <X className="h-5 w-5" /> : <Menu className="h-5 w-5" />}
Expand Down Expand Up @@ -159,6 +169,7 @@ export function AppShell({ children }: { children: ReactNode }) {
<Link
key={link.href}
href={link.href}
aria-current={pathname === link.href ? 'page' : undefined}
className={cn(
'w-full max-w-sm text-center px-6 py-5 text-xl font-medium rounded-2xl transition-colors',
pathname === link.href
Expand Down
7 changes: 6 additions & 1 deletion app/src/components/layout/ProjectStepNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,13 @@ export function ProjectStepNav({ projectId }: { projectId: string }) {

<Link
href={href}
// `step`, not `page`: this is a progress rail through one
// project, and aria-current="step" is the token for exactly
// that. It also reaches the 44px floor — these pills came out
// near 36px and are the primary way through the flow.
aria-current={isActive ? 'step' : undefined}
className={cn(
'relative flex items-center gap-1.5 sm:gap-2 px-2.5 sm:px-4 py-2 text-sm font-medium rounded-full transition-all whitespace-nowrap',
'relative flex min-h-11 items-center gap-1.5 sm:gap-2 px-2.5 sm:px-4 py-2 text-sm font-medium rounded-full transition-all whitespace-nowrap',
isActive
? 'bg-primary text-primary-foreground shadow-md shadow-primary/20'
: isComplete
Expand Down
Loading