fix(api): stop a failed surface delete from leaving a duplicate row - #45
Merged
Merged
Conversation
Upsert deleted the existing surface before inserting the new one but never checked the delete's result. If the delete silently failed (RLS misconfig, transient DB error), the insert left two rows for one project, and every later GET for that surface would 500 since it relies on .maybeSingle() expecting at most one row. Same unchecked-error family as PR #36/#37/#39/#40/#43.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/surfaces) deletes the existing surface row for a project, then inserts the new one — but never checked whether the delete succeeded.project_id. Every laterGET /api/surfaceswould then 500, since it relies on.maybeSingle(), which errors on more than one matching row.Test plan
npx tsc --noEmit— cleannpm run lint— 0 errors (8 pre-existing warnings, unrelated)npm run test— 96 passed, 0 failed (error-shape.test.tsandquery-error-checked.test.tsboth pass against the new code)🤖 Generated with Claude Code